Merged
Conversation
Contributor
|
nice. I created a spelling branch a while ago, but found the CI rejected modifications to many files, so I didn't continue with it. |
lowlighter
approved these changes
Aug 26, 2022
Owner
|
Sorry for the delay, thanks a lot for your contribution ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #1180 (comment)
This is basically the version I used to generate that PR.
Note that I've pinned it to
@v0.0.20which is the latest release. GitHub best practices suggest pinning to the SHA instead of the tag.As an aside, you probably want to configure dependabot to make PRs for github actions (it will definitely provide them for check-spelling).
The current model is that the workflow will comment on a push or a pull request. If there's an open pull request, it will try not to comment on the push. When it runs for a pull request, it will try to collapse the most recent pr comment. -- I'm currently investigating SARIF reporting which could change how things work (at least a little).
Here's a sample of talking to the workflow to update the
expect.txtfile: check-spelling-sandbox#4 -- note that as configured, it explicitly will not offer this for the primary repository. Any workflow with the ability to write into a repository is a risk, and thus in order to reduce risks for popular repositories, I'm generally suggesting that if projects want to use this feature (which does make it easier for contributors to update this file, as opposed to running commands on their local computer), it not be enabled in the primary repository.The
README.mdfile is just for readers and not used by the project.The
candidates.patternsfile isn't actually supported by 0.0.20 (but should be by the next version) -- it's used to make suggestions for adding entries intopatterns.txt(or a future filename for the same feature).It's probably worth reviewing the
expect.txtfile at least once to see if there are any items that jump out asfalse negatives= errors that should be corrected.If you run into problems, you can
@me. I'm fairly responsive.