Add GeoBoundingBox filter#84
Conversation
Toflar
left a comment
There was a problem hiding this comment.
Implemented as far as I could get with my knowledge.
Do you want me to take over from here or do you want to give it a shot with my feedback? You are almost there!
5f10424 to
dc88b89
Compare
fc86f25 to
bcf1922
Compare
|
@Toflar ready for review |
Toflar
left a comment
There was a problem hiding this comment.
Awesome! You have implemented almost all that's needed, great!!
Toflar
left a comment
There was a problem hiding this comment.
Just one more test I think would be very helpful.
This looks very cool - how do you like it? :)
| '_geoBoundingBox(location, 1.00 2.00, 2.00, 3.00)', | ||
| "Col 31: Error: Expected ',', got '2.00'", | ||
| ]; | ||
|
|
There was a problem hiding this comment.
Just one more test for invalid coordinates would be great :)
|
Oh and some docs on how to use the filter https://github.com/loupe-php/loupe/blob/main/docs/searching.md#filter |
9150db5 to
df140d9
Compare
Toflar
left a comment
There was a problem hiding this comment.
Some docs improvements and then I think this is ready to be merged. Awesome work, Alex!
Co-authored-by: Yanick Witschi <yanick.witschi@terminal42.ch>
|
Thanks @alexander-schranz! This is very cool! I'm going to clean up some stuff and then release it as v0.7 :) |
|
@Toflar Awesome. Thank you! |
Why Loupe already supports filtering by a GeoDistance. Which support we already merged also int SEAL. It would also be nice to filter by a bounding box (rectangle). That is mostly used for things when a user navigates around a map and have a specific area shown.
See fore more information: #83
fixes #83
Implemented as far as I could get with my knowledge.