Add default spawn point #708
Conversation
|
⏱️ Benchmark run finished in 0m 36s 📈 Compared against baseline: 30s 📅 Last benchmark: 2026-01-10 18:02:27 UTC You can retrigger the benchmark by commenting |
There was a problem hiding this comment.
Pull request overview
This PR adds default spawn point functionality for Minecraft world generation, ensuring that all newly generated Java worlds have a spawn point set (either user-selected or defaulting to X=1, Z=1). The spawn height is also increased from +2 to +3 blocks above terrain for improved safety.
Changes:
- Added
update_player_position_xzfunction to set spawn points using direct XZ coordinates - Modified spawn point logic to always set a default at (X=1, Z=1) when no user selection is made
- Increased spawn height from +2 to +3 blocks above terrain/ground level
- Removed default "checked" state from interior generation toggle in UI
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/world_editor/bedrock.rs | Updated spawn height calculation to add 3 blocks instead of 2 |
| src/gui/index.html | Removed "checked" attribute from interior-toggle checkbox |
| src/gui.rs | Added new function for XZ-based spawn updates and modified existing spawn logic to use default coordinates |
| src/data_processing.rs | Simplified spawn Y coordinate update logic to always run for Java worlds |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.