UI improvements #707
Merged
UI improvements #707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⏱️ Benchmark run finished in 0m 35s 📈 Compared against baseline: 30s 📅 Last benchmark: 2026-01-10 16:58:48 UTC You can retrigger the benchmark by commenting |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements several UI improvements across the application including icon replacements, accessibility enhancements, and visual polish for the map interface.
Changes:
- Replaced emoji-based icons with SVG icons for search and settings buttons for improved rendering consistency
- Added ESC key handler to close settings and license modals
- Implemented temporary hiding of world preview overlay during edit/delete mode to prevent visual confusion
- Enhanced landuse block generation with per-block randomization for residential and commercial areas to add visual variety
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/gui/maps.html | Replaced emoji search icon with SVG icon |
| src/gui/index.html | Replaced emoji settings gear icon with SVG icon |
| src/gui/css/styles.css | Updated modal z-index to 20001 to ensure proper layering above sidebar; updated settings button styles for SVG |
| src/gui/css/bbox.css | Added editing-mode styling for disabled preview button during edit/delete operations |
| src/gui/js/main.js | Added ESC key event listener to close settings and license modals |
| src/gui/js/bbox.js | Implemented hide/restore functions for world overlay during edit/delete mode and added corresponding event handlers |
| src/element_processing/landuse.rs | Moved RNG initialization earlier and added per-block randomization for residential and commercial landuse types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.