Skip to content

Conversation

@louis-e
Copy link
Owner

@louis-e louis-e commented Jan 6, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 6, 2026 16:01
@louis-e louis-e merged commit 4fecf98 into main Jan 6, 2026
@louis-e louis-e deleted the tiny-release-memory branch January 6, 2026 16:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds explicit memory releases at strategic points to free up memory earlier in long-running data processing operations. The changes use Rust's drop() function to release large data structures as soon as they are no longer needed, rather than waiting for them to go out of scope naturally.

  • Releases height_grid immediately after applying Gaussian blur in elevation processing
  • Releases elements and highway_connectivity after terrain element processing completes

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/elevation_data.rs Drops height_grid after blur operation to free memory before Minecraft height conversion
src/data_processing.rs Drops elements and highway_connectivity after element processing loop to free memory before ground generation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

⏱️ Benchmark run finished in 0m 31s
🧠 Peak memory usage: 823 MB

📈 Compared against baseline: 30s
🧮 Delta: 1s
🔢 Commit: 17cf778

🟢 Generation time is unchanged.

📅 Last benchmark: 2026-01-06 16:04:23 UTC

You can retrigger the benchmark by commenting retrigger-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants