Stream OSM parsing and reduce cloning #692
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
serde_json::Deserializer::from_reader(...)directly intoOsmDatainsrc/retrieve_data.rsand returnOsmDatainstead ofValue.OsmDataa public typed struct (includingremark) and updateparse_osm_datato acceptOsmDatainsrc/osm_parser.rs.ways_mapstorage withHashMap<u64, Arc<ProcessedWay>>and changeProcessedMemberto holdArc<ProcessedWay>to avoid cloning way node vectors repeatedly.nodes_mapandways_mapafter processing relations to release memory earlier and update call sites (src/test_utilities.rs) to use the new typed fetch return.Testing
cargo fmtto apply formatting changes and ensure code style is consistent, which completed successfully.Codex Task