Use Arc<Ground> for WorldEditor ground reference #690
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Grounddata when storing it inWorldEditorby sharing ownership withArc.Description
WorldEditor::groundfromOption<Box<Ground>>toOption<Arc<Ground>>and adduse std::sync::Arc.set_groundto acceptArc<Ground>and store it directly, and updateget_groundto returnOption<&Ground>usingas_deref().generate_world_with_optionswrap the providedGroundinArc::new(ground)and passArc::clone(&ground)toWorldEditor::set_ground, and update callers to useground.as_ref()where a&Groundis required.use std::sync::Arcimports and adjust call sites insrc/data_processing.rsto match the new API.Testing
Codex Task