fix: clamp Y coords and ensure region dir exists #686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses two distinct issues in the world editor: handling out-of-bounds Y coordinates and ensuring the region directory exists before creating region files.
Key Changes:
- Clamps Y coordinates to Minecraft's valid range (-64 to 319) in block accessor/mutator methods to prevent TryFromIntError panics
- Adds directory existence check and creation logic for the region directory before writing region files
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/world_editor/common.rs | Added MIN_Y/MAX_Y constants and clamping logic to get_block, set_block, and set_block_with_properties methods; replaced try_into().unwrap() with as casts |
| src/world_editor/java.rs | Added logic to ensure the region directory exists before creating region files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
⏱️ Benchmark run finished in 0m 34s 📈 Compared against baseline: 30s 🟢 Generation time is unchanged. 📅 Last benchmark: 2026-01-01 16:46:15 UTC You can retrigger the benchmark by commenting |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.