fix: skip session lock for bedrock world generation #685
+22
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the session lock was incorrectly being acquired for Bedrock world generation. The session lock is only needed for Java Edition worlds to prevent Minecraft from having the world open during generation. Bedrock worlds are generated as standalone .mcworld files that don't require this lock.
Key changes:
- Moved world format determination earlier in the generation flow to enable conditional session lock logic
- Made session lock acquisition conditional - only acquired for Java Edition worlds, skipped for Bedrock worlds
- Added explanatory comments clarifying the purpose and necessity of session locks for different world formats
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
⏱️ Benchmark run finished in 0m 29s 📈 Compared against baseline: 30s 🟢 Generation time is unchanged. 📅 Last benchmark: 2026-01-01 16:35:41 UTC You can retrigger the benchmark by commenting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.