Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 7, 2025

Spawn point Y coordinate updates were failing with "Latitude X not in range -90.0..=90.0" errors for locations where longitude exceeds ±90 degrees (e.g., Asia, Pacific regions).

Root cause: When reconstructing bbox strings for LLBBox::from_str(), coordinate accessors were called in wrong order, causing longitude values to be validated as latitude.

Change: Swapped accessor order in bbox_string formatting (data_processing.rs:287-290)

// Before: produced incompatible format
let bbox_string = format!("{},{},{},{}", 
    args.bbox.min().lng(), args.bbox.min().lat(),
    args.bbox.max().lng(), args.bbox.max().lat());

// After: matches LLBBox::from_str() expectations  
let bbox_string = format!("{},{},{},{}",
    args.bbox.min().lat(), args.bbox.min().lng(),
    args.bbox.max().lat(), args.bbox.max().lng());

This ensures reconstructed bbox strings use the same format as the original GUI input, allowing LLBBox::from_str() to parse them correctly.

Original prompt

This section details on the original issue you should resolve

<issue_title>[BUG] Failed to update spawn point Y coordinate</issue_title>
<issue_description>Failed to update spawn point Y coordinate: Failed to parse bounding box for spawn point:
Latitude 92.228851 not in range -90.0..=90.0
Failed to update spawn point Y coordinate: Failed to parse bounding box for spawn point:
Latitude -112.78337 not in range -90.0..=90.0</issue_description>

<agent_instructions>Identify why this warning occurs and evaluate how to fix it. Pay attention to not break previously working logic</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@github-actions
Copy link

github-actions bot commented Dec 7, 2025

⏱️ Benchmark run finished in 0m 33s
🧠 Peak memory usage: 1005 MB

📈 Compared against baseline: 30s
🧮 Delta: 3s
🔢 Commit: 07105f0

🟢 Generation time is unchanged.

📅 Last benchmark: 2026-01-10 12:18:42 UTC

You can retrigger the benchmark by commenting retrigger-benchmark.

Copilot AI and others added 3 commits December 7, 2025 14:11
Co-authored-by: louis-e <44675238+louis-e@users.noreply.github.com>
Co-authored-by: louis-e <44675238+louis-e@users.noreply.github.com>
Co-authored-by: louis-e <44675238+louis-e@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failed update of spawn point Y coordinate Fix spawn point Y coordinate update for longitude values outside ±90° Dec 7, 2025
Copilot AI requested a review from louis-e December 7, 2025 14:24
@louis-e louis-e marked this pull request as ready for review January 10, 2026 12:16
Copilot AI review requested due to automatic review settings January 10, 2026 12:16
@louis-e
Copy link
Owner

louis-e commented Jan 10, 2026

retrigger-benchmark

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a critical bug where spawn point Y coordinate updates failed for locations with longitude values exceeding ±90 degrees (e.g., Asia, Pacific regions), causing "Latitude X not in range -90.0..=90.0" validation errors.

Changes:

  • Fixed coordinate order in bbox string reconstruction (data_processing.rs) from lng,lat,lng,lat to lat,lng,lat,lng format
  • Added clarifying comments explaining the bbox string format requirements

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@louis-e louis-e merged commit 295ca41 into main Jan 10, 2026
8 checks passed
@louis-e louis-e deleted the copilot/fix-spawn-point-y-coordinate branch January 10, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Failed to update spawn point Y coordinate

2 participants