Bedrock support #653
Bedrock support #653
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
retrigger-benchmark |
|
⏱️ Benchmark run finished in 0m 28s 📈 Compared against baseline: 69s ✅ This PR improves generation time. 📅 Last benchmark: 2025-12-04 17:26:00 UTC You can retrigger the benchmark by commenting |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Lines 836 to 840 in a8e3170
When the GUI requests a Bedrock export with a custom spawn marker, gui_start_generation still calls update_player_position(&selected_world, …) before the format switch. For Bedrock flows selected_world is empty (no world was selected) and there is no level.dat yet, so update_player_position returns Level.dat not found and the generation aborts as soon as the user sets a spawn point. Bedrock generation with a user-defined spawn point is therefore broken; the spawn update should be skipped or pointed at the Bedrock output instead of the non-existent Java world.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.