fix dynmap, and maybe other things #534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
retrigger-benchmark |
|
⏱️ Benchmark run finished in 2m 15s 📈 Compared against baseline: 135s 🟢 Generation time is unchanged. You can retrigger the benchmark by commenting |
Owner
|
Thanks, I will look into this soon - I'm currently on vacation! :) |
Owner
|
Thanks for the PR, I think this is very useful since a few people already complained about this issue. I just added the block property insertion again since that was accidentally removed. Ready for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynmap expects
datato not exist if it would be of length 0. Other software may expect the same so I fixed it here rather than in DynmapI also deduped some code while I was at it