Skip to content

Conversation

@louis-e
Copy link
Owner

@louis-e louis-e commented May 29, 2025

WIP

image

@github-actions
Copy link

github-actions bot commented May 29, 2025

⏱️ Benchmark run finished in 0m 39s
🧠 Peak memory usage: 1616 MB

📈 Compared against baseline: 42s
🧮 Delta: -3s
🔢 Commit: dd22bbb

🟢 Generation time is unchanged.

You can retrigger the benchmark by commenting retrigger-benchmark.

@louis-e louis-e changed the title Buildings Improvements Buildings Overhaul Jun 1, 2025
@GMart
Copy link
Contributor

GMart commented Jun 3, 2025

Here is Notre Dame Cathedral in Paris. it almost works!
2025-06-02_22 51 36

@GMart
Copy link
Contributor

GMart commented Jun 3, 2025

However this is across the island, roof of the Conciergerie:
2025-06-02_22 59 32
You should be able to use the roof:height and roof:orientation attribute instead of calculating it. https://www.openstreetmap.org/way/248480552

@louis-e
Copy link
Owner Author

louis-e commented Jun 3, 2025

Thanks for your reviews @GMart, will respond to them asap! :) Just to let you know the PR isn't finished yet so a lot of stuff still looks weird haha! But I'm glad you like it so far!! :)

@louis-e
Copy link
Owner Author

louis-e commented Jul 19, 2025

retrigger-benchmark

@louis-e
Copy link
Owner Author

louis-e commented Jul 19, 2025

retrigger-benchmark

@louis-e
Copy link
Owner Author

louis-e commented Jul 20, 2025

retrigger-benchmark

@louis-e louis-e merged commit bd5a7b9 into main Jul 20, 2025
4 checks passed
@louis-e louis-e deleted the buildings-foundation branch August 21, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants