CI: fix benchmark time to not include build #457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Contributor
|
Is the hardware guaranteed to be the same across benchmark runs? I have no idea how GH actions runners are chosen/provisioned. |
Contributor
Author
Probably absolutely not. All I know the default runners are some Azure VMs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timing
cargo runmeans also timing the build if one doesn't exist.This splits the benchmark CI to build first, then just time the compiled binary.
A follow-up could be to use https://github.com/sharkdp/hyperfine so the benchmark is run a couple of times, but then you'd need to take into account how many times Hyperfine decides to run the benchmark, which is not something I want to implement in Bash math.
I adjusted the baseline duration accordingly in this PR.