Fix scaling of roads and building heights #444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix road widths to respect scaling. Buildings now respect scale for start_y_offset, fixing most floating buildings
Have stripes and aeroways respect the scaling. Stripes with the .floor() function never showed the stripes at a low scaling. ceil() seems to work. Undo accidental mod: with function in buildings.rs
Contributor
Author
|
retrigger-benchmark |
|
⏱️ Benchmark run finished in 2m 4s 📈 Compared against baseline: 130s 🟢 Generation time is unchanged. You can retrigger the benchmark by commenting |
Owner
|
Perfect, thanks a lot! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix road widths to respect scaling. Buildings now respect scale for start_y_offset, fixing most floating buildings
Fix #443
TODO:
Update: Fixed stripes. In a future PR we need to look at other things that have height when world scale is < 1, like trees