Skip to content

Conversation

@Oleg4260
Copy link
Contributor

@Oleg4260 Oleg4260 commented Apr 28, 2025

  • Fix custom layers being generated over ground level
  • Remove relative_to_absolute_y() because there's already get_absolute_y() that serves the same purpose
  • Remove unnecessary dirt filling, remove duplication of bedrock line
  • Fix crash caused by unicode symbols in place names

@Oleg4260
Copy link
Contributor Author

Oleg4260 commented Apr 28, 2025

Hi @louis-e , just noticed a few mistakes you made in your last PR, for example you forgot to put - in the lines that generate custom underground layers, which caused them to generate over ground level, and I decided to remove a function for getting absolute y that simply calls another function, so it's basically useless. Also the program started crashing when I tried to generate my hometown, because its name contains the ї symbol, which is a part of the Unicode, but now it's fixed
2025-04-28_11 10 41

@Oleg4260
Copy link
Contributor Author

Oleg4260 commented Apr 28, 2025

Btw, remember this performance test? It now takes only 18 seconds to generate this bbox with terrain enabled, which is over 4 times faster! You really improved the speed of ground generation amazingly

@louis-e
Copy link
Owner

louis-e commented Apr 28, 2025

Thanks for the extensive testing, I'm glad you caught some mistakes - let me know if you notice more! :)

Btw, remember this #421 (comment)? It now takes only 18 seconds to generate this bbox with terrain enabled, which is over 4 times faster! You really improved the speed of ground generation amazingly

Woah nice, I didn't expect it to make such a big difference!

@louis-e louis-e merged commit 1a0fc29 into louis-e:main Apr 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants