Minor improvements to farmland code #414
Conversation
| "farmland" => FARMLAND, | ||
| "farmland" => { | ||
| if args.winter { | ||
| DIRT |
There was a problem hiding this comment.
Speaking of this, I intentionally did not place a SNOW_BLOCK here to make the world look a little more realistic, I'm thinking of refactoring the winter mode to remove all the SNOW_BLOCKs and put SNOW_LAYER everywhere. In my opinion, the map should generate in the way to look similar to a normal minecraft world.
There was a problem hiding this comment.
I agree with this. We should open a separate discussion on how to implement that, since I imagine you'd do the snow layer last after all the normal blocks are placed... 🤷🏼♂️
|
Decided to do one more thing: I noticed that the Ground Level option is ignored when Terrain is enabled, and the MIN_Y = -62 const is used as the lowest terrain point. So I removed the const and this option is used instead, it's also -62 by default but this allows to elevate the map if needed, for example when you want to do some digging |
|
LGTM, thanks! |
Just a small change to the generation of farmlands: