Skip to content

Some improvements for the generation #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
louis-e merged 14 commits into from
Apr 10, 2025
Merged

Some improvements for the generation #403

louis-e merged 14 commits into from
Apr 10, 2025

Conversation

@Oleg4260
Copy link
Contributor

@Oleg4260 Oleg4260 commented Apr 5, 2025 •
edited
Loading

Changes:

  • Increased MAX_Y to 319 because it's the new height limit of Minecraft
  • Added more entries for the natural tag, like bare rock, glaciers and others
  • Removed trees from farmlands because trees don't grow randomly in the middle of land that is used for growing crops
  • Improved winter mode by replacing water with ice (except rivers) and removing crops from farmlands
  • Fixed vertical scaling so that it now matches horizontal scaling
  • Replaced 15x15 water grid in farmlands with singular water blocks every 8 blocks
  • Reworked generation of upper dirt layer, now there's no dirt under stone, sand and ice
  • Removed randomly scattered benches (3 oak log blocks) from parks

@Oleg4260 Oleg4260 changed the title Some improvements Some improvements for the generation Apr 5, 2025
@Oleg4260 Oleg4260 marked this pull request as draft April 6, 2025 14:52
@Oleg4260
Copy link
Contributor Author

Oleg4260 commented Apr 6, 2025 •
edited
Loading

Trying new water placement instead of the old 15x15 grid. I think this is better because less water is seen, also the old pattern didn't irrigate all the blocks
2025-04-06_18 26 24
2025-04-06_18 26 41

@Oleg4260 Oleg4260 marked this pull request as ready for review April 6, 2025 15:37
benjamin051000
benjamin051000 approved these changes Apr 6, 2025
View reviewed changes
@louis-e
Copy link
Owner

louis-e commented Apr 10, 2025

Thanks a lot for your great effort Oleg, and for the code review, Benjamin! Looks good to me, I'll merge it! FYI I will follow up with another merge on this to adapt a few details

@louis-e louis-e merged commit 6a1d6d3 into louis-e:main Apr 10, 2025
3 checks passed
@Oleg4260 Oleg4260 mentioned this pull request Apr 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@benjamin051000 benjamin051000 benjamin051000 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Oleg4260 @louis-e @benjamin051000