Remove gui-only deps when building cli #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamin051000
commented
Jan 22, 2025
Contributor
Author
benjamin051000
left a comment
There was a problem hiding this comment.
Let me know what you think. This removes unused warnings during cargo build --no-default-features.
261a232 to
5b9b789
Compare
0cd2b70 to
1d391cc
Compare
It looks like these are only GUI dependencies. I still need to test that it compiles, but these give unused warnings when compiling with the gui disabled.
1d391cc to
112481f
Compare
Contributor
Author
|
Right now main has 490 dependencies, this branch reduces it to 241 😎 My machine compiles it in 25s |
Owner
|
Hey Benjamin, I'll work through a few if not all of your pull requests tonight. Thanks a lot for your amazing effort in the past few weeks and sorry for catching up with it a bit late! :) |
Contributor
Author
|
No worries @louis-e ! I'm glad you're back :D I took a break as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like these are only GUI dependencies. I still need to test that it compiles, but these give unused warnings when compiling with the gui disabled.