Skip to content

Conversation

@wielandb
Copy link
Contributor

In my region, there are a lot of historic but not anymore existing railways tagged with railway=razed. Theese should not be rendered as well.

@wielandb
Copy link
Contributor Author

Hmmmm.... the checks fail because of a formatting error. Curiously, the formatting error that the check found was not what I committed, as is visible in the changed files section.

@hb0nd
Copy link
Contributor

hb0nd commented Jan 19, 2025

i agree the lint check reports are confusing, but it's in a diff format (+/-).

Here it is formatted in github markdown (it's complaining about a line being too long):

-        if ["proposed", "abandoned", "subway", "construction", "razed"].contains(&railway_type.as_str()) {
+        if ["proposed", "abandoned", "subway", "construction", "razed"]
+            .contains(&railway_type.as_str())
+        {
             return;
         }

other than that, the change looks good :)

@wielandb
Copy link
Contributor Author

Oh, so the lines marked with + are how it should be! Do I understand correct that I should change it to the way the check suggested?

@hb0nd
Copy link
Contributor

hb0nd commented Jan 19, 2025

Oh, so the lines marked with + are how it should be! Do I understand correct that I should change it to the way the check suggested?

yup that will make the check pass :)

@wielandb
Copy link
Contributor Author

Thanks for the clarification! Changed it. ✔

@wielandb
Copy link
Contributor Author

While exploring, I noticed that the value "turntable" should probably also not be rendered. Added it.

@louis-e
Copy link
Owner

louis-e commented Jan 20, 2025

Thanks a lot for your contribution! :)

@louis-e louis-e merged commit 4df4a3d into louis-e:main Jan 20, 2025
3 checks passed
@doruk3434
Copy link

nasıl haritayı açıp seçecez

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants