-
-
Notifications
You must be signed in to change notification settings - Fork 764
Add "razed" to values of railway=* not rendered #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hmmmm.... the checks fail because of a formatting error. Curiously, the formatting error that the check found was not what I committed, as is visible in the changed files section. |
|
i agree the lint check reports are confusing, but it's in a diff format ( Here it is formatted in github markdown (it's complaining about a line being too long): - if ["proposed", "abandoned", "subway", "construction", "razed"].contains(&railway_type.as_str()) {
+ if ["proposed", "abandoned", "subway", "construction", "razed"]
+ .contains(&railway_type.as_str())
+ {
return;
}other than that, the change looks good :) |
|
Oh, so the lines marked with |
yup that will make the check pass :) |
|
Thanks for the clarification! Changed it. ✔ |
|
While exploring, I noticed that the value "turntable" should probably also not be rendered. Added it. |
|
Thanks a lot for your contribution! :) |
|
nasıl haritayı açıp seçecez |
In my region, there are a lot of historic but not anymore existing railways tagged with railway=razed. Theese should not be rendered as well.