Miscellaneous fixes #290
Merged
Miscellaneous fixes #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lack of window.__TAURI__ object prevents most of the JS code from running (this change stubs it which allows the Tauri GUI to be tested in a web browser with a simple web server like PHP's one)
For some reason the background color isn't applied on input boxes (only on WebKit) if I don't set this
Closed
Owner
|
Thanks a lot for your research and fixes for these bugs! :) |
| import { licenseText } from './license.js'; | ||
|
|
||
| const { invoke } = window.__TAURI__.core; | ||
| if (window.__TAURI__) { |
There was a problem hiding this comment.
Sorry, but this change is causing an issue when trying to load world due to invoke now being scoped only inside the if block. You'll need to create a let variable above (in the global scope), for example, and assign it the value of this invoke.
(screenshot after changing the code a tiny bit to display the `errorCode`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #244
Supersedes #275