Skip to content

Conversation

@TheComputerGuy96
Copy link
Contributor

This also adds a Lithuanian translation (it may not be the best though)

@sh2kcs
Copy link
Contributor

sh2kcs commented Jan 15, 2025

nice work!

These 2 strings are a duplicate of existing ones (which should
reduce translation boilerplate a bit)
This will make adding a new translation a bit easier (this change
also accepts full codes for language variations like en-UK or pt-BR)

Also specify a full code for English and Chinese translations (Chinese
variation was found with a translation tool's language detector so
it might not be accurate)
This removes all of the boilerplate for setting strings (now the
strings are set by looping through an object and calling a helper function)

The helper function also has an English string fallback if a translation
doesn't have one

And finally some functions/.html code were adjusted to simplify the localization
helper function (this also means innerHTML is no longer used for safety)
There's some strings coming from the Rust side though (which
will require extra code work)
This may be strange in some places though
@louis-e
Copy link
Owner

louis-e commented Jan 21, 2025

Sorry for the late response, but this is really great - thank you very much for your effort! :)

@louis-e louis-e merged commit a52ba2b into louis-e:main Jan 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants