Skip to content

Conversation

@Salmonings
Copy link
Contributor

Just love the idea and the project so a little bit of contributing might help! Here's the Arabic locales for the program! Just be careful as Arabic is a RTL language so it might go wrong/weird

Just love the idea and the project so a little bit of contributing might help! Here's the Arabic locales for the program! Just be careful as Arabic is a RTL language so it might go wrong/weird
Comment on lines +12 to +13
"select_a_location_first": "!حدد الموقع أولا",
"select_a_minecraft_world_first": "!حدد عالم ماين كرافت أولاً",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should remove these lines (these aren't used by Arnis and I'll remove them in a future MR)

Copy link

@makhlwf makhlwf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this translation and attempting to add the Arabic translation localization into this program. I very like your translation, though I have suggested some enhancements to give the translation more clearness.

@@ -0,0 +1,35 @@
{
"select_location": "اختر الموقع",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest changing this to إختيار موقع

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Unfortunately, I am unsure of how to change it in this pull request, and currently I am unavailable. If possible, feel free to adjust and clarify these translations. Some translations were matched with some of Minecrafts translations.

{
"select_location": "اختر الموقع",
"zoom_in_and_choose": "قم بالتكبير واختر منطقتك باستخدام أداة المستطيل",
"select_world": "حدد العالم",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest changing this too تحديد عالم

"select_location": "اختر الموقع",
"zoom_in_and_choose": "قم بالتكبير واختر منطقتك باستخدام أداة المستطيل",
"select_world": "حدد العالم",
"choose_world": "اختار العالم",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest editing this too إختيار عالم

"zoom_in_and_choose": "قم بالتكبير واختر منطقتك باستخدام أداة المستطيل",
"select_world": "حدد العالم",
"choose_world": "اختار العالم",
"no_world_selected": "لم يتم تحديد العالم",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest removing the ال article from this line

"select_world": "حدد العالم",
"choose_world": "اختار العالم",
"no_world_selected": "لم يتم تحديد العالم",
"start_generation": "بدء الجيل",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The الجيل word in this line is not clear and it doesn't give any sense so I suggest changing the line to بدأ البناء to give it more clarity

"floodfill_timeout": ":مهلة ملء الفيضان (ثانية)",
"ground_level": ":مستوى الأرض",
"choose_world_modal_title": "اختار العالم",
"select_existing_world": "حدد العالم الموجود",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest changing this to إختيار عالم موجود مسبقا so it makes more sense

"customization_settings": "إعدادات التخصيص",
"footer_text": "© {year} Arnis v{version} من louis-e",
"new_version_available": ".هناك نسخة جديدة متاحة! انقر هنا لتنزيلها",
"minecraft_directory_not_found": "لم يتم العثور على دليل ماين كرافت",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest changing the word دليل to مجلد so more people can understand this

"new_version_available": ".هناك نسخة جديدة متاحة! انقر هنا لتنزيلها",
"minecraft_directory_not_found": "لم يتم العثور على دليل ماين كرافت",
"world_in_use": "العالم المحدد قيد الاستخدام حاليًا",
"failed_to_create_world": "فشل في إنشاء عالم جديد",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest changing this to حدث خطا عند محاولة إنشاء عالم جديد

"minecraft_directory_not_found": "لم يتم العثور على دليل ماين كرافت",
"world_in_use": "العالم المحدد قيد الاستخدام حاليًا",
"failed_to_create_world": "فشل في إنشاء عالم جديد",
"no_world_selected_error": "لم يتم تحديد العالم",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest removing the ال article from the word العالم to the sentence so it makes more sense

"failed_to_create_world": "فشل في إنشاء عالم جديد",
"no_world_selected_error": "لم يتم تحديد العالم",
"select_minecraft_world_first": "!حدد عالم ماين كرافت أولاً",
"select_location_first": "!حدد الموقع أولا",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest changing the word الموقع a little bit to موقعا so it makes more sense

@louis-e
Copy link
Owner

louis-e commented Jan 21, 2025

Thanks for your effort! I'll wait until the enhancement suggestions are resolved and then merge it :)

@makhlwf
Copy link

makhlwf commented Mar 18, 2025

Hi @Salmonings,

I hope you're doing well. I noticed there hasn’t been an update on this PR for a while. I left some feedback a couple of months back and was wondering if you’re planning to update it soon. If you’d prefer, I’d be happy to help incorporate the improvements—or even consider merging my translation PR (#291) if that works better for the project’s timeline.

I’m eager to see Arabic localization in the project, so please let me know how I can help move this forward.

Thanks!

@louis-e
Copy link
Owner

louis-e commented Apr 10, 2025

Will merge this and manually patch some translation corrections. Thanks a lot guys! :)

@louis-e louis-e merged commit 8a4961a into louis-e:main Apr 10, 2025
3 checks passed
@Salmonings
Copy link
Contributor Author

I'm so grateful for the Arabic language integration. I apologize that I haven't yet had the opportunity to review the suggested edits. I understand these are important and I'll try to make time for them soon. Thank you for your patience and understanding. I appreciate the work you've put into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants