Linux fixes #197
Merged
Linux fixes #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
The GTK 3 backend of rfd is relatively problematic (it causes a whole app freeze when the command function isn't async and a SIGABRT on app exit when it is async: tauri-apps/plugins-workspace#2255) so use the better-working xdg-portal backend instead (this will also help with Flatpak compatibility) This also removes the unused tauri-plugin-dialog dependency (which conflicts with our rfd features)
After adding extra dependencies, that build job turns green again This is basically a revert of 5a215c1
042fd0d to
8999fc9
Compare
Owner
|
Looks good to me, thanks a lot! |
Contributor
|
Whoa, that's so weird. Before #127, specifying "rfd = x.x.x" in this way resulted in a compile fail on Linux... I wonder what changed since then, or what I got wrong in that PR? 🤷🏼♂️ Now it compiles, runs, and the file picker opens! So I'm happy! Confused... but happy! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the folder picker to work on Linux (at least if xdg-desktop-portal is installed)
Fixes #145