net_http adapter: Backport the code of #38 to version 1.0.1#39
Merged
olleolleolle merged 1 commit intoJul 24, 2024
Merged
Conversation
`env[:ssl]` is an instance of `Faraday::SSLOptions`, and as a result, `configure_ssl` is always executed, even when the connection is to HTTP. Fixes lostisland#37
Member
|
@ma2gedev I will make a 1-0-stable branch, where https://github.com/lostisland/faraday-net_http/tree/v1.0.1 is. |
Member
|
@ma2gedev Now, there exists a branch. |
Contributor
Author
|
@olleolleolle Thank you so much! ❤️ |
Member
|
@ma2gedev In order to get to a release of 1.0.2, there was a little oil change needed. But now, I think any subsequent 1-0-stable release can be done using our automation. https://rubygems.org/gems/faraday-net_http/versions/1.0.2 now exists. |
Contributor
Author
|
@olleolleolle Thank you for your work about both of 1.0.2 and 3.1.1. ❤️ |
Member
|
No, thank you for suggesting it! |
|
thank you everyone involved here, as someone who is stuck on faraday v1 still, it is much appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the backport of #38 to version v1.0.1 .
Could you create a branch for version 1.0.1 (something like 1.x)? I've temporarily set the target branch to main, but I will change the target branch of the PR to the new one afterwards.