CI: Use Ruby 3.3 for linting#35
Merged
Merged
Conversation
RuboCop is set to use 2.6 syntax rules in any case.
78b1043 to
76ca526
Compare
Member
|
Next release will drop Ruby 2.6 and 2.7 anyway, so feel free to remove them in this PR if it helps getting CI green 👍 |
76ca526 to
638ee1e
Compare
iMacTia
approved these changes
Jan 9, 2024
Member
Author
|
The real reason was "used a bundled Bundler which had some older issues", but now, we got rid of the 2.6, 2.7 from the CI matrix. Should we bump the gemspec min required Ruby version, too, @iMacTia ? |
Member
|
Yes we'll need to bump it in the gem spec and also in the rubocop.yml file. |
Member
Author
|
@iMacTia I will refrain from checking for version restriction on the net-http gem, but the rest of the things are here, and I will merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RuboCop is set to use 2.6 syntax rules in any case.
Turned out to need a newer RuboCop, and newer plugins, and after that, it was ready to be used.