Adding ability to specify the version of helm-docs to use.#301
Merged
losisin merged 4 commits intolosisin:mainfrom Mar 12, 2025
Merged
Adding ability to specify the version of helm-docs to use.#301losisin merged 4 commits intolosisin:mainfrom
losisin merged 4 commits intolosisin:mainfrom
Conversation
losisin
requested changes
Mar 12, 2025
Owner
losisin
left a comment
There was a problem hiding this comment.
pls fix the tests and also you need to run npm run package and commit dist/
Contributor
Author
Yea, sorry I didn't see the |
9048690 to
e84c32d
Compare
Contributor
Author
|
@losisin - I've done the following and confirmed locally that tests now pass 👍 |
Owner
|
@davidcollom Try npm run format:write |
643eee1 to
54570c5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #301 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 95 96 +1
Branches 11 12 +1
=========================================
+ Hits 95 96 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
losisin
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes allow for specifying the version of Helm-Docs along side setting true Boolean values for GitPush and failOnDiff