Skip to content

ENH add show_lines to plot_marginal#186

Merged
mayer79 merged 2 commits intomainfrom
show_lines
Nov 12, 2024
Merged

ENH add show_lines to plot_marginal#186
mayer79 merged 2 commits intomainfrom
show_lines

Conversation

@lorentzenchr
Copy link
Copy Markdown
Owner

@lorentzenchr lorentzenchr commented Nov 9, 2024

Fixes #177.
plot_marginal gets a new argument show_lines with options:

  • "always"
  • "numerical"

@lorentzenchr lorentzenchr requested a review from mayer79 November 10, 2024 17:55
Copy link
Copy Markdown
Collaborator

@mayer79 mayer79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I was thinking about the argument options "numeric" instead of "numerical", but that is a detail.

@lorentzenchr
Copy link
Copy Markdown
Owner Author

Looking up some sources for English, it seem it is a "numerical feature", therefore numerical.

@mayer79 mayer79 merged commit ab620c2 into main Nov 12, 2024
@lorentzenchr lorentzenchr deleted the show_lines branch November 12, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ENH Show optional lines in plot_marginal() et al

2 participants