Conversation
There was a problem hiding this comment.
Code Review
This pull request implements a codebase-wide refactoring to improve formatting and consistency, adopting modern Go practices like 'any' and the 'maps' package. Critical compilation errors were identified in the test suites for DeviceFlowProvider and antigravity versioning, where 'sync.WaitGroup' is incorrectly used with a non-existent 'Go' method.
| wg.Go(func() { | ||
| _ = provider.GetCredentials() | ||
| }() | ||
| }) |
There was a problem hiding this comment.
The sync.WaitGroup type does not have a Go method. This change will cause a compilation error. The previous implementation using wg.Add(1) and a goroutine with defer wg.Done() is the correct way to use a standard Go wait group.
wg.Add(1)
go func() {
defer wg.Done()
_ = provider.GetCredentials()
}()| wg.Go(func() { | ||
| initOnce.Do(func() { f.init(context.Background()) }) | ||
| }() | ||
| }) |
There was a problem hiding this comment.
The sync.WaitGroup type (declared on line 142) does not have a Go method. This refactoring will break the build. Please revert to the standard wg.Add(1) and go func() { defer wg.Done(); ... }() pattern.
wg.Add(1)
go func() {
defer wg.Done()
initOnce.Do(func() { f.init(context.Background()) })
}()
Uh oh!
There was an error while loading. Please reload this page.