feat: expose inbound request headers to override templates#1520
Conversation
Add filtered inbound request headers to the Request Override template context so channels can reuse non-sensitive client headers in body and header overrides. Support canonical and lowercase lookups, keep first-value semantics, and document the behavior in both zh and en guides. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Greptile SummaryThis PR exposes filtered inbound client request headers as Confidence Score: 5/5Safe to merge — sensitive-header filtering is correct, the dual canonical/lowercase storage is sound, and the new helper also fixes a subtle pre-existing case-sensitivity gap in MergeHTTPHeaders and MaskSensitiveHeaders. All changes are well-tested with five targeted unit tests. Sensitive headers are filtered before exposure via IsSensitiveHeader. The buildRequestHeaderMap dual-key design works correctly because http.CanonicalHeaderKey always produces a mixed-case result distinct from strings.ToLower. No P0/P1 findings. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Inbound HTTP Request\nwith raw headers] --> B[buildRequestHeaderMap]
B --> C{IsSensitiveHeader?}
C -- yes --> D[Skip header\nauth, api-key, cookie…]
C -- no --> E[Store canonical key\ne.g. X-Trace-Id → value]
E --> F[Store lowercase key\ne.g. x-trace-id → value]
F --> G[RequestHeader map\nin RenderContext]
G --> H[Go template execution\n{{index .RequestHeader "x-trace-id"}}]
H --> I1[Body override\noverride_parameters / body_ops]
H --> I2[Header override\nheader_ops]
Reviews (1): Last reviewed commit: "feat: expose inbound request headers to ..." | Re-trigger Greptile |
There was a problem hiding this comment.
Code Review
This pull request adds support for accessing filtered inbound client headers in request override templates via the new .RequestHeader variable. The implementation includes sensitive header filtering and supports both canonical and lowercase key lookups. Documentation and tests have been updated to reflect these changes. A potential nil pointer dereference was identified in the buildRenderContext function which could lead to a panic if the request object is missing.
| func buildRenderContext(llmReq *llm.Request, requestModel string) RenderContext { | ||
| return RenderContext{ | ||
| RequestModel: requestModel, | ||
| Model: llmReq.Model, | ||
| Metadata: llmReq.Metadata, | ||
| RequestHeader: buildRequestHeaderMap(llmReq), | ||
| ReasoningEffort: llmReq.ReasoningEffort, | ||
| } | ||
| } |
There was a problem hiding this comment.
The buildRenderContext function is susceptible to a nil pointer dereference if llmReq is nil, as it accesses fields like llmReq.Model directly. Although buildRequestHeaderMap (called on line 65) includes a nil check for llmReq, the panic would occur on line 63 before that function is even executed. Given that the nil check exists in the helper, it implies that llmReq might be nil in some execution paths, so this function should be made safe.
func buildRenderContext(llmReq *llm.Request, requestModel string) RenderContext {
if llmReq == nil {
return RenderContext{
RequestModel: requestModel,
RequestHeader: make(map[string]string),
}
}
return RenderContext{
RequestModel: requestModel,
Model: llmReq.Model,
Metadata: llmReq.Metadata,
RequestHeader: buildRequestHeaderMap(llmReq),
ReasoningEffort: llmReq.ReasoningEffort,
}
}|
Inbound request headers 覆盖好像没什么意义吧 |
目前是用来对齐codex/claude code的session id，从header中取数据对齐到一个header上 |
|
请求覆盖在 trace 生成之后，所以可能用不上 |
|
可能我们的场景有点特别，axonhub的上游是另一个网关，session id是给上游做cache用的 |
Summary
.RequestHeaderin Request Override template context using filtered inbound client headersTest plan
go test ./internal/server/orchestrator -run 'TestOverrideParametersWithTemplate|TestOverrideParametersWithRequestHeaderTemplate|TestOverrideParametersWithRequestHeaderTemplate_LowercaseSensitiveHeaders|TestOverrideParametersWithRequestHeaderTemplate_NoRawRequest|TestOverrideHeadersWithRequestHeaderTemplate|TestOverrideHeadersKeepJSONLikeString' -vcd llm && go test ./httpclient -run 'TestMergeHTTPHeaders_BlocksAllHardcodedHeaders|TestMaskSensitiveHeaders_MasksAllHardcodedHeaders|TestHeaderMaps_CanonicalForm' -v🤖 Generated with Claude Code