fix(xiaomi): map models provided mimo token plan as xiaomi models#1501
Conversation
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
There was a problem hiding this comment.
Code Review
This pull request adds several new Xiaomi models (mimo-v2.5-pro, mimo-v2.5, and mimo-v2-tts) to the providers configuration and resets the costs for existing models to zero. It also updates the synchronization script to merge models from specific Xiaomi token plans into the main Xiaomi provider entry. Feedback was provided regarding inconsistencies in the family field for the new models and a potential discrepancy between the attachment flag and supported modalities for the Pro version.
| { | ||
| "id": "mimo-v2.5-pro", | ||
| "name": "MiMo-V2.5-Pro", | ||
| "family": "mimo-v2.5-pro", |
There was a problem hiding this comment.
The family field for mimo-v2.5-pro is inconsistent with other Xiaomi models in this file (which use mimo). This may affect how models are grouped or filtered in the user interface.
| "family": "mimo-v2.5-pro", | |
| "family": "mimo", |
| { | ||
| "id": "mimo-v2.5", | ||
| "name": "MiMo-V2.5", | ||
| "family": "mimo-v2.5", |
There was a problem hiding this comment.
The family field for mimo-v2.5 is inconsistent with other Xiaomi models (which use mimo). For consistent grouping in the UI, it should match the rest of the series.
| "family": "mimo-v2.5", | |
| "family": "mimo", |
| "input": [ | ||
| "text" | ||
| ], |
There was a problem hiding this comment.
There is a discrepancy between the attachment: true flag and the listed modalities for mimo-v2.5-pro. Since the base mimo-v2.5 model supports image, audio, video, and pdf, the Pro version should likely support these as well, or at least pdf if it supports file attachments.
#1499
the upsteam do have these mimo v2.5 models, but them exist in mimo-token-plan-cn so I add a mapping from it