fix: Prevent app crash while moving presets (LoopKit#540)

bastiaanv · web-flow · commit 3ce43ded238a · 2024-08-21T10:03:57.000-05:00
diff --git a/LoopKitUI/View Controllers/OverrideSelectionViewController.swift b/LoopKitUI/View Controllers/OverrideSelectionViewController.swift
@@ -388,7 +388,8 @@ public final class OverrideSelectionViewController: UICollectionViewController,
             return originalIndexPath
         }
 
-        return proposedIndexPath == indexPathOfCustomOverride()
+        let customPresetRow = self.collectionView(collectionView, numberOfItemsInSection: proposedIndexPath.section) - 2
+        return proposedIndexPath.row >= customPresetRow
             ? originalIndexPath
             : proposedIndexPath
 

Original file line number	Diff line number	Diff line change
`@@ -388,7 +388,8 @@ public final class OverrideSelectionViewController: UICollectionViewController,`
`388`	`388`	`return originalIndexPath`
`389`	`389`	`}`
`390`	`390`
`391`		`- return proposedIndexPath == indexPathOfCustomOverride()`
	`391`	`+ let customPresetRow = self.collectionView(collectionView, numberOfItemsInSection: proposedIndexPath.section) - 2`
	`392`	`+ return proposedIndexPath.row >= customPresetRow`
`392`	`393`	`? originalIndexPath`
`393`	`394`	`: proposedIndexPath`
`394`	`395`