Merged
Conversation
raymondfeng
reviewed
Mar 26, 2020
raymondfeng
reviewed
Mar 26, 2020
4ce89f3 to
bd2ad6e
Compare
raymondfeng
approved these changes
Mar 26, 2020
Contributor
Author
|
Coverage decrease is unrelated but it dropped because sometimes the geocoder test will throw 502 and skip this line even though we check if the service is available before running related tests. |
dhmlau
approved these changes
Mar 26, 2020
Member
dhmlau
left a comment
There was a problem hiding this comment.
LGTM. I don't know the details but the content is understandable to me.
I have 2 review comments.
bd2ad6e to
ee5181c
Compare
ee5181c to
492095e
Compare
Documentation for application developers to use `@loopback/rest-crud` and extension developers to use `@loopback/model-api-builder`.
492095e to
85a9391
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2740.
Documentation for application developers to use
@loopback/rest-crudand extension developers to use@loopback/model-api-builder.Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈