Skip to content

fix: server union type contains null#3520

Closed
jannyHou wants to merge 1 commit intomasterfrom
fix/http-server-type
Closed

fix: server union type contains null#3520
jannyHou wants to merge 1 commit intomasterfrom
fix/http-server-type

Conversation

@jannyHou
Copy link
Contributor

@jannyHou jannyHou commented Aug 7, 2019

The address() method from net module has null in its union type, which results in build error in the http-server module. See pic 1:
Screen Shot 2019-08-07 at 6 31 20 PM

The type definition of address from net module:

Screen Shot 2019-08-07 at 6 31 56 PM

I am not very familiar with the address resolve, so treated null as an empty string here. Should we throw error if it's null?

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@jannyHou
Copy link
Contributor Author

jannyHou commented Aug 8, 2019

@jannyHou jannyHou closed this Aug 8, 2019
@jannyHou jannyHou mentioned this pull request Aug 9, 2019
7 tasks
@jannyHou jannyHou deleted the fix/http-server-type branch September 12, 2019 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant