Merged
Conversation
0d56867 to
5e7c493
Compare
raymondfeng
reviewed
Apr 29, 2019
241ccbc to
47c8184
Compare
nabdelgadir
commented
Apr 30, 2019
examples/lb3-application/src/__tests__/acceptance/lb3app.acceptance.ts
Outdated
Show resolved
Hide resolved
bajtos
suggested changes
May 2, 2019
examples/lb3-application/lb3app/server/boot/create-sample-models.js
Outdated
Show resolved
Hide resolved
examples/lb3-application/src/__tests__/acceptance/lb3app.acceptance.ts
Outdated
Show resolved
Hide resolved
examples/lb3-application/src/__tests__/acceptance/lb3app.acceptance.ts
Outdated
Show resolved
Hide resolved
examples/lb3-application/src/__tests__/acceptance/lb3app.acceptance.ts
Outdated
Show resolved
Hide resolved
examples/lb3-application/src/__tests__/acceptance/lb3app.acceptance.ts
Outdated
Show resolved
Hide resolved
This was referenced May 2, 2019
7 tasks
nabdelgadir
commented
May 4, 2019
examples/lb3-application/src/__tests__/acceptance/lb3app.acceptance.ts
Outdated
Show resolved
Hide resolved
b-admike
suggested changes
May 8, 2019
Contributor
b-admike
left a comment
There was a problem hiding this comment.
Looks great overall, I've tried out the steps and left some feedback for instructions.
examples/lb3-application/src/__tests__/acceptance/lb3app.acceptance.ts
Outdated
Show resolved
Hide resolved
bajtos
reviewed
May 9, 2019
Member
bajtos
left a comment
There was a problem hiding this comment.
You are making great progress 👏
examples/lb3-application/lb3app/server/boot/create-sample-models.js
Outdated
Show resolved
Hide resolved
examples/lb3-application/src/__tests__/acceptance/lb3app.acceptance.ts
Outdated
Show resolved
Hide resolved
61e4f5b to
6c571c3
Compare
bajtos
approved these changes
May 13, 2019
Member
bajtos
left a comment
There was a problem hiding this comment.
LGTM. Please get approval from other reviewers before landing.
This an example showing how to add an existing LoopBack 3 application to a LoopBack 4 project. Co-authored-by: Miroslav Bajtoš <mbajtoss@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2392.
Implements a new example illustrating how the
booter-lb3apppackage'sLb3AppBooterComponentworks for mounting a LoopBack 3 application in a LoopBack 4 project.Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈