feat: add booter-lb3app package by nabdelgadir · Pull Request #2682 · loopbackio/loopback-next

nabdelgadir · 2019-04-03T15:11:50Z

Closes #2391.

This PR adds the booter-lb3app package that assists in booting and mounting a LoopBack 3 application and exposing its REST API through LoopBack 4.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

npm test passes on your machine
New tests added or existing tests modified to cover all changes
Code conforms with the style guide
API Documentation in code was updated
Documentation in /docs/site was updated
Affected artifact templates in packages/cli were updated
Affected example projects in examples/* were updated

packages/booter-lb3app/package.json

packages/booter-lb3app/src/__tests__/acceptance/booter-lb3app.acceptance.ts

bajtos

The implementations looks pretty good. I see that you have followed the checklist for adding new packages, kudos for that 👏

Let's improve the test suite now. I find the current test suite as too difficult to reason about. There are many fixture files adding lot of functionality on top of default LB3 & LB4 applications, it's not clear what is relevant for the LB3 booter and what's just "random stuff copied from elsewhere".

Ideally, I'd like the test suite to be more focused. Start with a minimal LB3 application with a single model, place this e.g. to /fixtures/minimal-app. In your test code, create a minimal LB4 application. I think you don't even need to create any new class, just call new RestApplication. Configure this LB4 app with the new booter and start it. Then verify that the endpoints from LB3 were exposed as expected. I think that's good enough for the first version of this feature. We can add more tests later to verify more complex configuration, if we ever discover any problems there.

packages/booter-lb3app/package.json

packages/booter-lb3app/src/__tests__/acceptance/booter-lb3app.acceptance.ts

packages/booter-lb3app/src/__tests__/fixtures/legacy/common/models/coffee-shop.js

packages/booter-lb3app/src/__tests__/fixtures/src/application.ts

packages/booter-lb3app/src/__tests__/fixtures/src/coffee.controller.ts

packages/booter-lb3app/src/__tests__/fixtures/src/datasources/ds.datasource.json

packages/booter-lb3app/src/__tests__/fixtures/src/sequence.ts

packages/booter-lb3app/src/lb3app.booter.ts

b-admike

I've went through most of the commit (minus some updating deps), and overall the patch looks great 👍.

packages/booter-lb3app/src/__tests__/acceptance/booter-lb3app.acceptance.ts

docs/site/MONOREPO.md

greenkeeper.json

b-admike · 2019-04-22T13:28:17Z

packages/booter-lb3app/src/__tests__/acceptance/booter-lb3app.acceptance.ts

    });
  });

+  context('open API spec endpoints', () => {


b-admike · 2019-04-22T13:32:37Z

packages/booter-lb3app/src/__tests__/acceptance/booter-lb3app.acceptance.ts

      ]);
    });
+
+    context('LoopBack 3 authentication', () => {


Nice test coverage 👍

packages/booter-lb3app/README.md

packages/booter-lb3app/fixtures/legacy/common/models/coffee-shop.js

packages/booter-lb3app/package.json

packages/booter-lb3app/src/lb3app.booter.component.ts

packages/booter-lb3app/src/lb3app.booter.ts

b-admike

LGTM

Co-authored-by: Miroslav Bajtoš <mbajtoss@gmail.com>

nabdelgadir changed the title ~~feat: add booter-lb3app package~~ [WIP] feat: add booter-lb3app package Apr 3, 2019

nabdelgadir self-assigned this Apr 4, 2019

bajtos added Boot feature Migration labels Apr 5, 2019

nabdelgadir force-pushed the lb3-booter branch 4 times, most recently from f21ec34 to a697d00 Compare April 11, 2019 17:56

nabdelgadir force-pushed the lb3-booter branch 2 times, most recently from c69ed7d to 86e416b Compare April 12, 2019 17:15

nabdelgadir commented Apr 12, 2019

View reviewed changes

packages/booter-lb3app/package.json Outdated Show resolved Hide resolved

nabdelgadir commented Apr 12, 2019

View reviewed changes

packages/booter-lb3app/src/__tests__/acceptance/booter-lb3app.acceptance.ts Show resolved Hide resolved

nabdelgadir marked this pull request as ready for review April 12, 2019 17:24

nabdelgadir requested review from b-admike, bajtos, hacksparrow, jannyHou and raymondfeng as code owners April 12, 2019 17:24

nabdelgadir force-pushed the lb3-booter branch 2 times, most recently from 8951de5 to 4d2dd1e Compare April 12, 2019 20:09

nabdelgadir changed the title ~~[WIP] feat: add booter-lb3app package~~ feat: add booter-lb3app package Apr 15, 2019

nabdelgadir force-pushed the lb3-booter branch from 4d2dd1e to 386f9c1 Compare April 15, 2019 13:06

bajtos suggested changes Apr 15, 2019

View reviewed changes

nabdelgadir force-pushed the lb3-booter branch from 386f9c1 to bb25047 Compare April 17, 2019 23:24

nabdelgadir requested a review from bajtos April 17, 2019 23:25

nabdelgadir force-pushed the lb3-booter branch 3 times, most recently from a28a88f to 465743e Compare April 22, 2019 13:27

b-admike reviewed Apr 22, 2019

View reviewed changes

nabdelgadir force-pushed the lb3-booter branch 2 times, most recently from 444b49a to 70de24c Compare April 22, 2019 17:09

raymondfeng reviewed Apr 22, 2019

View reviewed changes

packages/booter-lb3app/README.md Outdated Show resolved Hide resolved

raymondfeng reviewed Apr 22, 2019

View reviewed changes

packages/booter-lb3app/fixtures/legacy/common/models/coffee-shop.js Show resolved Hide resolved

raymondfeng reviewed Apr 22, 2019

View reviewed changes

packages/booter-lb3app/package.json Outdated Show resolved Hide resolved

raymondfeng reviewed Apr 22, 2019

View reviewed changes

packages/booter-lb3app/package.json Outdated Show resolved Hide resolved

nabdelgadir force-pushed the lb3-booter branch from 70de24c to 576e2a7 Compare April 23, 2019 17:12

nabdelgadir commented Apr 23, 2019

View reviewed changes

packages/booter-lb3app/src/lb3app.booter.component.ts Outdated Show resolved Hide resolved

nabdelgadir force-pushed the lb3-booter branch from 576e2a7 to 175cb79 Compare April 23, 2019 17:17

raymondfeng reviewed Apr 23, 2019

View reviewed changes

packages/booter-lb3app/src/lb3app.booter.component.ts Outdated Show resolved Hide resolved

raymondfeng reviewed Apr 23, 2019

View reviewed changes

packages/booter-lb3app/src/lb3app.booter.ts Outdated Show resolved Hide resolved

nabdelgadir force-pushed the lb3-booter branch from 175cb79 to 55fd360 Compare April 23, 2019 17:56

b-admike approved these changes Apr 23, 2019

View reviewed changes

raymondfeng approved these changes Apr 23, 2019

View reviewed changes

nabdelgadir force-pushed the lb3-booter branch 3 times, most recently from c122fd5 to 694daf8 Compare April 24, 2019 13:14

feat: add booter-lb3app package

898fac3

Co-authored-by: Miroslav Bajtoš <mbajtoss@gmail.com>

nabdelgadir force-pushed the lb3-booter branch from 694daf8 to 898fac3 Compare April 24, 2019 13:23

dhmlau mentioned this pull request Apr 24, 2019

Example of using remote connector with LB4 #1696

Closed

nabdelgadir merged commit 993a97f into master Apr 24, 2019

nabdelgadir deleted the lb3-booter branch April 24, 2019 13:49

Conversation

nabdelgadir commented Apr 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

Uh oh!

Uh oh!

bajtos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

b-admike left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

b-admike Apr 22, 2019

Choose a reason for hiding this comment

Uh oh!

b-admike Apr 22, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

b-admike left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nabdelgadir commented Apr 3, 2019 •

edited

Loading