fix: #1643: import MetadataAccessor direct from metadata… #1644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… TypeScript 3 compiler issue
Contributor
Author
|
Note: I got a CloudFront error on submitting the CLA agreement. It shows OK here, but I don't know if something might be a little wrong behind the scenes. |
raymondfeng
approved these changes
Aug 24, 2018
Contributor
|
@mgabeler-lee-6rs Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to avoid TypeScript 3 compiler issue
Fixes #1643 by changing places that import
MetadataAcessorfrom@loopback/contextto be from@loopback/metadata, and add the reference to that in the correspondingpackage.jsonfiles.Checklist
npm testpasses on your machineAPI Documentation in code was updatedN/ADocumentation in /docs/site was updatedN/AAffected artifact templates inN/Apackages/cliwere updatedAffected example projects inN/Aexamples/*were updatedI also, naturally, verified that this fixes the build issues in my project.
I'm not quite sure how to add tests within the repo to verify this change.