Skip to content

Allow List to take items as instances of a class#1625

Merged
raymondfeng merged 2 commits intomasterfrom
fix-list-of-class-instances
Sep 17, 2018
Merged

Allow List to take items as instances of a class#1625
raymondfeng merged 2 commits intomasterfrom
fix-list-of-class-instances

Conversation

@raymondfeng
Copy link
Contributor

@raymondfeng raymondfeng commented Sep 17, 2018

Description

Supersedes #1624

Related issues

  • connect to <link_to_referenced_issue>

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

@@ -0,0 +1,119 @@
'use strict';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add MIT license header on new files?

Copy link
Contributor

@b-admike b-admike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@raymondfeng raymondfeng merged commit 242fd1b into master Sep 17, 2018
@raymondfeng raymondfeng deleted the fix-list-of-class-instances branch September 17, 2018 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants