input: Update paint argument for GPUI API change.#1839
Merged
huacnlee merged 1 commit intolongbridge:mainfrom Dec 22, 2025
Merged
input: Update paint argument for GPUI API change.#1839huacnlee merged 1 commit intolongbridge:mainfrom
huacnlee merged 1 commit intolongbridge:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a breaking change in the ShapedLine::paint API that was introduced in PR #45417. The API now requires two additional parameters: TextAlign and an optional max width. The fix adds these parameters to all ShapedLine::paint calls in the input UI components.
Key Changes
- Added
TextAlignimport to both text_wrapper.rs and element.rs - Updated four
ShapedLine::paintcalls to includeTextAlign::LeftandNoneas the new required parameters - Updated gpui and related dependencies to a newer commit that includes the API changes
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/ui/src/input/text_wrapper.rs | Added TextAlign import and updated internal ShapedLine::paint call with new parameters |
| crates/ui/src/input/element.rs | Added TextAlign import and updated three ShapedLine::paint calls (ghost lines, line numbers, and completion text) with new parameters |
| Cargo.lock | Updated gpui and related dependencies to commit 213cb30, consolidated wayland-protocols versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the input element break caused by PR zed-industries/zed#45417