fix: macOS appstore rejection #893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR resolves macOS App Store rejection by refining the CI pipeline for faster, repeatable Flutter analysis and updating macOS entitlements for App Store compliance, plus adding a supportive wiki. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `.github/workflows/analysis.yml:32` </location>
<code_context>
+ - name: Cache pub dependencies
+ uses: actions/cache@v4
+ with:
+ path: |
+ ${{ env.PUB_CACHE }}
+ ~/.pub-cache
+ ${{ runner.tool_cache }}/flutter
+ key: ${{ runner.os }}-pub-${{ hashFiles('**/pubspec.lock') }}
+ restore-keys: |
</code_context>
<issue_to_address>
Including runner.tool_cache/flutter in pub cache may be unnecessary.
Caching this directory may unnecessarily increase cache size and restore times. Please verify if it's essential for dependency caching or should be handled separately.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
path: |
${{ env.PUB_CACHE }}
~/.pub-cache
${{ runner.tool_cache }}/flutter
=======
path: |
${{ env.PUB_CACHE }}
~/.pub-cache
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+32
to
+35
| path: | | ||
| ${{ env.PUB_CACHE }} | ||
| ~/.pub-cache | ||
| ${{ runner.tool_cache }}/flutter |
There was a problem hiding this comment.
suggestion (performance): Including runner.tool_cache/flutter in pub cache may be unnecessary.
Caching this directory may unnecessarily increase cache size and restore times. Please verify if it's essential for dependency caching or should be handled separately.
Suggested change
| path: | | |
| ${{ env.PUB_CACHE }} | |
| ~/.pub-cache | |
| ${{ runner.tool_cache }}/flutter | |
| path: | | |
| ${{ env.PUB_CACHE }} | |
| ~/.pub-cache |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #892
Summary by Sourcery
Improve CI performance with shallow checkout and caching, update macOS entitlements to resolve App Store rejection, and add supporting wiki documentation.
Bug Fixes:
CI:
Documentation: