Skip to content

Conversation

@lollipopkit
Copy link
Owner

@lollipopkit lollipopkit commented Sep 2, 2025

…nError

Remove manual field assignment in ContainerNotifier.build() method since the generated Riverpod code already handles field initialization automatically. This prevents the 'Field client has already been initialized' error that was causing the Docker container page to display blank content.

Fixes #883

Summary by Sourcery

Bug Fixes:

  • Remove redundant manual field assignments in ContainerNotifier.build since Riverpod generated code handles initialization automatically, resolving the LateInitializationError.

…nError

Remove manual field assignment in ContainerNotifier.build() method since
the generated Riverpod code already handles field initialization automatically.
This prevents the 'Field client has already been initialized' error that was
causing the Docker container page to display blank content.

Fixes #883

Co-authored-by: lollipopkit🏳️‍⚧️ <lollipopkit@users.noreply.github.com>
@sourcery-ai
Copy link

sourcery-ai bot commented Sep 2, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removed redundant manual field assignments in ContainerNotifier.build(), relying on generated Riverpod code for initialization to prevent LateInitializationError and blank Docker interface.

File-Level Changes

Change Details Files
Eliminate redundant manual field initialization in the notifier build method
  • Removed 'this.client = client' assignment
  • Removed 'this.userName = userName' assignment
  • Removed 'this.hostId = hostId' assignment
  • Removed 'this.context = context' assignment
lib/data/provider/container.dart

Assessment against linked issues

Issue Objective Addressed Explanation
#883 Fix the blank Docker container page issue on macOS 15.3 after upgrading to v1231.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@lollipopkit lollipopkit merged commit 6b52679 into main Sep 2, 2025
2 checks passed
@lollipopkit lollipopkit deleted the claude/issue-883-20250902-0153 branch September 2, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v1231 docker blank page

2 participants