Skip to content

fix: Systemd shows nothing (#848) #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lollipopkit merged 1 commit into from
Aug 13, 2025
Merged

fix: Systemd shows nothing (#848) #850

lollipopkit merged 1 commit into from
Aug 13, 2025

Conversation

@shamnad-sherief
Copy link
Contributor

@shamnad-sherief shamnad-sherief commented Aug 13, 2025 •
edited by sourcery-ai bot
Loading

Summary by Sourcery

Improve systemd provider to correctly discover and display units by expanding file lookup paths, refactoring the shell lookup script, and cleaning up code formatting

New Features:

  • Include standard library unit directories (/lib/systemd/system, /usr/lib/systemd/system) in unit discovery

Bug Fixes:

  • Restore listing of systemd units by expanding and correcting the file lookup logic

Enhancements:

  • Refactor and simplify the shell script for finding unit files by consolidating helper functions and moving sorting to the end
  • Reformat multi-line method calls and constructor invocations for improved readability

@sourcery-ai
Copy link

sourcery-ai bot commented Aug 13, 2025 •
edited
Loading

Reviewer's Guide

This PR refactors parameter and object instantiation formatting for readability and overhauls the _getUnitsCmd shell script to consistently discover systemd unit files across all standard system and user directories.

Class diagram for updated SystemdProvider methods

classDiagram
class SystemdProvider {
  +Future<void> loadUnits()
  +Future<List<SystemdUnit>> _parseUnitObj(List<String> unitNames, SystemdUnitScope scope)
  -late final _getUnitsCmd
  +String _getIniVal(String line)
}
class SystemdUnit {
  +String name
  +String type
  +SystemdUnitScope scope
  +String state
  +String description
}
SystemdProvider --> SystemdUnit
Loading

File-Level Changes

Change Details Files
Refactor parsing method signature, calls, and mapping chains to multi-line format
  • Expanded _parseUnitObj signature parameters to separate lines
  • Reformatted calls to _parseUnitObj with each argument on its own line
  • Split the unitNames mapping chain into multiple lines
  • Converted SystemdUnit constructor to a multi-line named-parameter format
 lib/data/provider/systemd.dart
Rewrite and simplify the _getUnitsCmd shell script for unit discovery
  • Unified and simplified get_files function logic
  • Removed get_type_files function and conditional root branches
  • Added search paths: /etc, /lib, /usr/lib, and user config directories
  • Piped final results through sort to ensure deterministic ordering
 lib/data/provider/systemd.dart

Possibly linked issues

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot approved these changes Aug 13, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shamnad-sherief - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@lollipopkit lollipopkit merged commit e4a9875 into lollipopkit:main Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shamnad-sherief @lollipopkit