Improvements to dependents UI#572
Merged
loic-sharma merged 17 commits intoloic-sharma:masterfrom Aug 19, 2020
Merged
Conversation
loic-sharma
reviewed
Aug 17, 2020
loic-sharma
reviewed
Aug 17, 2020
loic-sharma
reviewed
Aug 17, 2020
loic-sharma
reviewed
Aug 17, 2020
loic-sharma
reviewed
Aug 17, 2020
loic-sharma
reviewed
Aug 17, 2020
Owner
|
This is awesome! I left a few minor comments, I'll merge this in once you address them. |
Owner
|
Could you also rename this heading to |
Co-authored-by: Loïc Sharma <sharma.loic@gmail.com>
Co-authored-by: Loïc Sharma <sharma.loic@gmail.com>
…kroyd99/BaGet into feature/da/dependents-ui
Contributor
Author
|
Think I've resolved all your comments, thanks for being so helpful 👍 |
loic-sharma
reviewed
Aug 19, 2020
loic-sharma
reviewed
Aug 19, 2020
Owner
|
Thanks for the contribution, this is awesome! 🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #570
Thanks for assigning this issue to me :) Decided to only return the information from the API that is actually required to build up the table, just to make it more performant. If you want me to change any of this I can 👍