Make the "Version" column case insensitive#466
Merged
loic-sharma merged 2 commits intomasterfrom Feb 9, 2020
Merged
Conversation
loic-sharma
commented
Feb 8, 2020
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL" Version="3.1.0" /> | ||
| <PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL" Version="3.1.1.2" /> |
Owner
Author
There was a problem hiding this comment.
This package upgrade is necessary as npgsql's identity migration is broken on v3.1.0. This was fixed in 3.1.1.1.
loic-sharma
commented
Feb 8, 2020
This was referenced Feb 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
BaGet is case sensitive on versions, which prevents unlisting/deleting a package that has uppercased letters in its version string (see #458). This only affects the SQLite and PostgreSQL drivers.
SQLite
⚠SQLite does not support altering columns (see this). Customers will need to recreate their database and then reupload all their packages to get this fix:
rm baget.dbcd packagesdotnet nuget push .\**\*.nupkg --source http://localhost:5000/v3/index.jsonImplementation
Test plan