Skip to content

Refactor BaGet#261

Merged
loic-sharma merged 1 commit intomasterfrom
controller-refactor
Aug 14, 2019
Merged

Refactor BaGet#261
loic-sharma merged 1 commit intomasterfrom
controller-refactor

Conversation

@loic-sharma
Copy link
Owner

@loic-sharma loic-sharma commented Apr 23, 2019

Refactors BaGet:

  1. Moves business logic out of controllers and into BaGet.Core. For example, the PackageContentController passes requests to IBaGetPackageContentService and maps results to HTTP responses. In effect, controllers are just translate HTTP translators.
  2. BaGet's services for the NuGet protocol implement the same interfaces as BaGet's client libraries for the NuGet protocol. For example, AzureSearchService and SearchClient both implement ISearchService
  3. Requests and responses are codified by models in BaGet.Protocol. For example, both SearchController.SearchAsync and SearchClient.SearchAsync return a SearchResponse

@loic-sharma loic-sharma mentioned this pull request Apr 25, 2019
@loic-sharma loic-sharma marked this pull request as ready for review August 12, 2019 16:07
@loic-sharma loic-sharma merged commit 3ae40a3 into master Aug 14, 2019
@loic-sharma loic-sharma deleted the controller-refactor branch August 14, 2019 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant