Skip to content

Fix when adding a field to the model in the editor the name of the field will not be filled#51

Merged
loic-lopez merged 27 commits into
masterfrom
bugfix/50-umvceditorbug-when-adding-a-field-to-the-model-in-the-editor-the-name-of-the-field-will-not-be-filled
Apr 16, 2022
Merged

Fix when adding a field to the model in the editor the name of the field will not be filled#51
loic-lopez merged 27 commits into
masterfrom
bugfix/50-umvceditorbug-when-adding-a-field-to-the-model-in-the-editor-the-name-of-the-field-will-not-be-filled

Conversation

@loic-lopez

@loic-lopez loic-lopez commented Apr 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Owner

Resolves #50

@loic-lopez loic-lopez linked an issue Apr 13, 2022 that may be closed by this pull request
[UMVC.Editor][Bug] when adding a field to the model in the editor the name of the field will not be filled #50
Closed
@loic-lopez loic-lopez self-assigned this Apr 13, 2022
@loic-lopez loic-lopez added bug Something isn't working UMVC Editor UMVC issue labels Apr 13, 2022
@codecov

codecov Bot commented Apr 15, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #51 (e7b2240) into master (ccda4b5) will increase coverage by 15.00%.
The diff coverage is 80.95%.

❗ Current head e7b2240 differs from pull request most recent head 9cb5670. Consider uploading reports for the commit 9cb5670 to get more accurate results

@@             Coverage Diff             @@
##           master      #51       +/-   ##
===========================================
+ Coverage   70.42%   85.43%   +15.00%     
===========================================
  Files          44       41        -3     
  Lines        1180      961      -219     
  Branches       16       16               
===========================================
- Hits          831      821       -10     
+ Misses        338      129      -209     
  Partials       11       11
Impacted Files Coverage Δ
...Implementations/UnitySerializableModelComponent.cs 0.00% <ø> (ø)
Assets/UseCases/Mvc/MvcModel.cs 100.00% <ø> (ø)
Assets/UseCases/Mvc/MvcView.cs 25.00% <0.00%> (ø)
Assets/UMVC/Editor/Windows/CreateMVCWindow.cs 61.61% <80.00%> (+3.10%) ⬆️
Assets/UMVC/Editor/Models/SettingsModel.cs 100.00% <100.00%> (ø)
Assets/UMVC/Editor/Windows/CreateSettingsWindow.cs 86.53% <100.00%> (-0.74%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@loic-lopez loic-lopez force-pushed the bugfix/50-umvceditorbug-when-adding-a-field-to-the-model-in-the-editor-the-name-of-the-field-will-not-be-filled branch from 3bdaadc to e334d41 Compare April 15, 2022 20:33
@loic-lopez loic-lopez force-pushed the bugfix/50-umvceditorbug-when-adding-a-field-to-the-model-in-the-editor-the-name-of-the-field-will-not-be-filled branch 2 times, most recently from 5b4e073 to d65a275 Compare April 16, 2022 07:53
@loic-lopez loic-lopez force-pushed the bugfix/50-umvceditorbug-when-adding-a-field-to-the-model-in-the-editor-the-name-of-the-field-will-not-be-filled branch 3 times, most recently from 6086da8 to 0eaedf0 Compare April 16, 2022 09:41
@loic-lopez loic-lopez force-pushed the bugfix/50-umvceditorbug-when-adding-a-field-to-the-model-in-the-editor-the-name-of-the-field-will-not-be-filled branch from 0eaedf0 to cf84f36 Compare April 16, 2022 09:41
@loic-lopez loic-lopez force-pushed the bugfix/50-umvceditorbug-when-adding-a-field-to-the-model-in-the-editor-the-name-of-the-field-will-not-be-filled branch from aea673f to 463aa9b Compare April 16, 2022 10:04
@loic-lopez loic-lopez force-pushed the bugfix/50-umvceditorbug-when-adding-a-field-to-the-model-in-the-editor-the-name-of-the-field-will-not-be-filled branch from 00a0f3a to f890071 Compare April 16, 2022 14:17
@loic-lopez loic-lopez force-pushed the bugfix/50-umvceditorbug-when-adding-a-field-to-the-model-in-the-editor-the-name-of-the-field-will-not-be-filled branch from f890071 to 2da959f Compare April 16, 2022 14:26
@loic-lopez loic-lopez force-pushed the bugfix/50-umvceditorbug-when-adding-a-field-to-the-model-in-the-editor-the-name-of-the-field-will-not-be-filled branch from 6fe4927 to e243314 Compare April 16, 2022 15:02
@loic-lopez loic-lopez force-pushed the bugfix/50-umvceditorbug-when-adding-a-field-to-the-model-in-the-editor-the-name-of-the-field-will-not-be-filled branch from e243314 to e7b2240 Compare April 16, 2022 15:03
@loic-lopez
+semver: feature
9cb5670 
- Update requirements by only run on unity 2021.x
- Migrate TypeReference to com.solidalloy.type-references v2.14.0
@loic-lopez loic-lopez merged commit 2d45551 into master Apr 16, 2022
@loic-lopez loic-lopez deleted the bugfix/50-umvceditorbug-when-adding-a-field-to-the-model-in-the-editor-the-name-of-the-field-will-not-be-filled branch April 16, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@loic-lopez loic-lopez

Labels

bug Something isn't working UMVC Editor UMVC issue

Projects

UMVC.Editor
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[UMVC.Editor][Bug] when adding a field to the model in the editor the name of the field will not be filled

1 participant

@loic-lopez