Skip to content

fix: Deprecate :graph/current in the electron state #11013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andelf merged 2 commits into from
Feb 29, 2024
Merged

fix: Deprecate :graph/current in the electron state #11013

andelf merged 2 commits into from
Feb 29, 2024

Conversation

@farcaller
Copy link
Contributor

@farcaller farcaller commented Feb 18, 2024 •
edited
Loading

This removes all use of :graph/current in the electron state, and fixes the issue where git autocommit will only work on the last opened graph. Fixes #11011.

@farcaller farcaller changed the title Make all calls to git require the graph path to operate on Deprecate :graph/current in the electron state Feb 18, 2024
@farcaller farcaller changed the title Deprecate :graph/current in the electron state fix: Deprecate :graph/current in the electron state Feb 18, 2024
@farcaller farcaller force-pushed the get-graph-path branch 2 times, most recently from 8c881f8 to 1a4097c Compare February 19, 2024 12:49
@andelf andelf requested review from andelf and xyhp915 February 20, 2024 08:12
@farcaller farcaller force-pushed the get-graph-path branch 2 times, most recently from f57037a to e860d4f Compare February 23, 2024 09:25
andelf
andelf approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@andelf andelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andelf andelf merged commit 227f3ef into logseq:master Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andelf andelf andelf approved these changes

@xyhp915 xyhp915 Awaiting requested review from xyhp915

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Logseq git autocommit breaks on multiple graphs open

2 participants

@farcaller @andelf