Skip to content

Conversation

@xyhp915
Copy link
Collaborator

@xyhp915 xyhp915 commented Feb 7, 2024

  • enhance: polish accent color UI details
  • feat: support three dots button for the favorites/recent page items
  • fix: more compatible classical CSS vars

@github-actions github-actions bot added the :type/enhancement Enhancement to product. Does not affect the overall basic use. label Feb 7, 2024
@xyhp915 xyhp915 changed the title Enhance/accent color related details Enhance(UI): accent color related details Feb 7, 2024
@xyhp915 xyhp915 requested review from andelf and tiensonqin February 7, 2024 04:44
@andelf
Copy link
Collaborator

andelf commented Feb 7, 2024

image image

If the accent color is already set before using the ui, "cancel" is the current color scheme.

@chronos1970
Copy link

Thanks for your work on this PR. I have noticed another issue since the introduction of the accent color theme. When resizing the Logseq window, the default turquoise color is shown as a background before (quickly) being overwritten by the correct background color. Let me know if I should open a separate issue for this.

Screenshot during resizing:
Clipboard_02-07-2024_01

Platform: Windows 10 Pro 64 bit
Logseq: v0.10.6
Plugins: tested with and without any plugins

@xyhp915
Copy link
Collaborator Author

xyhp915 commented Feb 7, 2024

image image
If the accent color is already set before using the ui, "cancel" is the current color scheme.

The arrow may be removed in the future because the arrow shadow is a trap.

CleanShot 2024-02-07 at 16 51 12@2x

@xyhp915
Copy link
Collaborator Author

xyhp915 commented Feb 7, 2024

Thanks for your work on this PR. I have noticed another issue since the introduction of the accent color theme. When resizing the Logseq window, the default turquoise color is shown as a background before (quickly) being overwritten by the correct background color. Let me know if I should open a separate issue for this.

Screenshot during resizing: Clipboard_02-07-2024_01

Platform: Windows 10 Pro 64 bit Logseq: v0.10.6 Plugins: tested with and without any plugins

Thanks for your feedback! This is a known issue and will be fixed as soon as possible in another branch :)

Copy link
Collaborator

@logseq-cldwalker logseq-cldwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🚢 This branch fixes an issue I was seeing where the Bullet Threading plugin and using an accented color results in no visible bullet. I haven't QAed anything else

Copy link
Collaborator

@andelf andelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@andelf andelf merged commit b9dd442 into master Feb 8, 2024
@andelf andelf deleted the enhance/accent-color-details branch February 8, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:type/enhancement Enhancement to product. Does not affect the overall basic use.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants