feature: new keybinding for "toggle expand/collapse this block" #10980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue logseq#9676 Binds to mod + ; by default.
xyhp915
approved these changes
Feb 18, 2024
andelf
approved these changes
Feb 20, 2024
Collaborator
andelf
left a comment
There was a problem hiding this comment.
LGTM. Works as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a keyboard shortcut to toggle the expanded/collapsed state of the currently edited or selected block(s), addressing requests made here:
The new keybinding defaults to
mod + ;by default. It works by checking whether the focused block is currently expanded or collapsed, and invokingcollapse!orexpand!respectively. Scenarios where the whiteboard UI is active, or where no block is currently being edited/selected, are left as no-ops for now.