fix: input-selection-end is not firing correctly #10113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efdd7f1 to
c5c625a
Compare
tiensonqin
approved these changes
Aug 30, 2023
Contributor
tiensonqin
left a comment
There was a problem hiding this comment.
Works great! 💯
Thanks for the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10106
This PR uses the
selectevent instead of themouseupevent for firing theinput-selection-endevent (logseq.Editor.onInputSelectionEnd). This eliminates some unexpected behaviors reported in #10106 and enables keyboard interactions.Manually tested and it works. And the selection of multiple blocks is not affected.